[19.0][MIG] report_positioned_image: Migration to 19.0 - #1193
Open
AungKoKoLin1997 wants to merge 6 commits into
Open
[19.0][MIG] report_positioned_image: Migration to 19.0#1193AungKoKoLin1997 wants to merge 6 commits into
AungKoKoLin1997 wants to merge 6 commits into
Conversation
Currently translated at 100.0% (30 of 30 strings) Translation: reporting-engine-18.0/reporting-engine-18.0-report_positioned_image Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-18-0/reporting-engine-18-0-report_positioned_image/it/
OCA-git-bot
added
series:19.0
mod:report_positioned_image
yostashiro
approved these changes
Aug 28, 2026
yostashiro
left a comment
yostashiro
left a comment
Member
There was a problem hiding this comment.
Code review and functional test. LGTM.
Member
|
/ocabot merge nobump |
Contributor
|
Sorry @yostashiro you are not allowed to merge. To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons. If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the |
Member
|
Oops. This was a mistake. Apologies for the noise: #1193 (comment) |
yostashiro
added a commit
to qrtl/ocj-oca
that referenced
this pull request
Aug 28, 2026
…ity (#35) Vendors two OCA modules from `OCA/reporting-engine`: | Module | Source | Commit | |---|---|---| | `report_positioned_image` | [#1193](OCA/reporting-engine#1193) (open, not yet on `19.0`) | `30d0138` | | `report_qweb_element_page_visibility` | `19.0` branch | `b730d60` | The second is a dependency of the first and is not otherwise reachable from this project's addons path, since ocj aggregates no upstream OCA repositories. It is already on the upstream `19.0` branch, so that copy is redundant with upstream and can be retired if `reporting-engine` is ever aggregated directly. Each module's origin is recorded below as a `Vendored from <repo>@<sha> (<ref>)` line, so a later re-sync can tell which upstream commit the copy is — which matters most for `report_positioned_image`, whose source is a PR head that can move or be closed. [QT7096](https://www.quartile.co/web#id=7096&cids=3&menu_id=506&action=1457&model=project.task&view_type=form) Vendored from OCA/reporting-engine@30d0138 (refs/pull/1193/head) Vendored from OCA/reporting-engine@b730d60 (19.0) Assisted-by: Claude Opus 5
smorita7749
approved these changes
Aug 31, 2026
smorita7749
left a comment
smorita7749
left a comment
There was a problem hiding this comment.
Code and functional review: LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@qrtl QT7096